Skip to content

Inline RGBAxes._config_axes to its only call site. #17174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2020
Merged

Inline RGBAxes._config_axes to its only call site. #17174

merged 1 commit into from
Apr 30, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 17, 2020

This is not called from anywhere else, and inlining avoids confusion
with other unrelated methods called _config_axes in other classes.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Inline RGBAxes._config_axes to its only call site.
083f580 
This is not called from anywhere else, and inlining avoids confusion
with other unrelated methods called _config_axes in other classes.
@anntzer anntzer added this to the v3.3.0 milestone Apr 17, 2020
@tacaswell tacaswell merged commit 0e900cf into matplotlib:master Apr 30, 2020
@anntzer anntzer deleted the unconfig_axes branch April 30, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Maintenance topic: mpl_toolkit
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @tacaswell