Update configuration of CircleCI builds #17183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
61b2fc3 to
d77458e
Compare
|
I opted to just convert everything; see separate commits for individual changes, and the initial post for a new description of what this does. |
1 task
This allows embedding multiple steps into a command.
The `save_cache` and `restore_cache` entries need to be separate steps, not keys on the `run` step.
With re-usable commands, we can put those steps onto the command instead of in each job.
This probably doesn't save much time, but will save the intersphinx files in a cache that will hopefully reduce download errors.
tacaswell
approved these changes
Jun 8, 2020
tacaswell
reviewed
Jun 8, 2020
|
|
||
| - run: *doc-bundle | ||
| - store_artifacts: | ||
| path: doc/build/sphinx-gallery-files.tar.gz |
There was a problem hiding this comment.
I'm not sure; it was originally there to confirm that sphinx-gallery was working, but that seems rather rare these days. On the other hand, it really doesn't spend much time doing this at all.
timhoffm
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I noticed that CircleCI didn't seem to be doing any caching. This was because
save_cacheandrestore_cachewere on therunstep, but really should have been separate steps.Before doing that however, I re-wrote the config to use CircleCI's new re-usable command style (as opposed to using YAML anchors). Since this allows multiple steps in each named command, it allows removing some duplicated steps and putting the cache in the right place. Finally, I added a cache for Sphinx's doctrees. This is not intended to provide much speedup (it's about 30s out of 7m for me), but rather to hold on to the intersphinx mappings because we seem to fail to download them periodically.
These are in separate commits for slightly easier review.
PR Checklist