-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Document Transform.__add__
and .__sub__
.
#17218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@QuLogic the link to circleci artefacts is broken? |
Maybe important to note that |
Ah yes, very good point. I pushed a wording which may be a bit awkward though, feel free to propose a better phrasing. |
@anntzer Yes, it's because you have CircleCI enabled on your fork scientific-python/circleci-artifacts-redirector-action#7. |
Ah ok, disabled it then, and fixed the typo. |
This is very helpful. A couple of suggestions to more fully close #17217.
|
|
Yes, and that was not crystal clear from the doctoring. |
"doctoring" is an interesting autocorrect for "docstring" :-) |
Oops. Anyhoo, sorry for the flake8 can you fix if you approve because the web editor is apparently unable to stop itself from inserting lots of spaces |
... the order of operations is really not clear from the existing doc string.
done with a small edit. |
Thanks definitely an improvement. I still think a quick blurb at the top of the module would help... |
PR Summary
Closes #17217.
PR Checklist