Skip to content

Add support for suptitle() in tight_layout(). #17219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2020
Merged

Add support for suptitle() in tight_layout(). #17219

merged 1 commit into from
Apr 27, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 22, 2020 •
edited
Loading

PR Summary

The padding between the suptitle and the axes is the same as around all
axes, which is consistent with the behavior of constrained_layout.

Depends on #17205.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Apr 22, 2020
jklymak
jklymak approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the new commit look good to me. Not sure they actually depend on the other PR?

@anntzer
Copy link
Contributor Author

anntzer commented Apr 22, 2020

Not really, but I'd rather not deal with the rebase, and I have possibly more tight_layout stuff coming (perhaps).

@anntzer
Add support for suptitle() in tight_layout().
0f26a46 
The padding between the suptitle and the axes is the same as around all
axes, which is consistent with the behavior of constrained_layout.
@tacaswell tacaswell merged commit b55f8c5 into matplotlib:master Apr 27, 2020
@anntzer anntzer deleted the tls branch April 28, 2020 07:16
@anntzer anntzer mentioned this pull request Jun 29, 2020
Closed
@anntzer anntzer mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @tacaswell