Skip to content

Warn on invalid savefig keyword arguments #17223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 15, 2020
Merged

Warn on invalid savefig keyword arguments #17223

merged 4 commits into from
Jun 15, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 23, 2020 •
edited
Loading

PR Summary

This depends on #17221 and #17233 so that there are no warnings about metadata from saving SVG or PDF with the PGF backend.

Fixes #192.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic force-pushed the savefig-extra-kwargs branch from 0bd3491 to cb47539 Compare April 23, 2020 06:02
@QuLogic QuLogic force-pushed the savefig-extra-kwargs branch from cb47539 to f74575c Compare June 10, 2020 19:09
@QuLogic QuLogic marked this pull request as ready for review June 10, 2020 19:13
@QuLogic
Copy link
Member Author

QuLogic commented Jun 10, 2020

Now ready, as the metadata PRs went in.

@tacaswell tacaswell added this to the v3.3.0 milestone Jun 10, 2020
anntzer
anntzer reviewed Jun 11, 2020
View reviewed changes
anntzer
anntzer reviewed Jun 11, 2020
View reviewed changes
@QuLogic QuLogic force-pushed the savefig-extra-kwargs branch from f74575c to f25f1eb Compare June 12, 2020 01:02
@QuLogic
Copy link
Member Author

QuLogic commented Jun 12, 2020

I changed it into a decorator, as @anntzer requested. I wonder if also args should be removed from the final methods?

@QuLogic QuLogic force-pushed the savefig-extra-kwargs branch from f25f1eb to b7a574f Compare June 12, 2020 01:24
@anntzer
Copy link
Contributor

anntzer commented Jun 15, 2020 •
edited
Loading

Also removing args seems good to me?

@anntzer
Copy link
Contributor

anntzer commented Jun 15, 2020

postci

@QuLogic QuLogic merged commit 7b76234 into matplotlib:master Jun 15, 2020
@QuLogic QuLogic deleted the savefig-extra-kwargs branch June 15, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
API: consistency
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

Savefig does not issue a warning on a non-existent keyword n
3 participants
@QuLogic @anntzer @tacaswell