Add the "contour.linewidths" configuration option #17236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It defaults to None whcih makes it to fallback to "lines.linewidth" option.
timhoffm
reviewed
Apr 29, 2020
|
Linting test is now is failing because of the "default: :rc..." which makes the line too long. |
timhoffm
reviewed
May 1, 2020
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
timhoffm
reviewed
May 4, 2020
timhoffm
approved these changes
May 4, 2020
|
Is it plural |
|
@QuLogic It's the plural like the argument to |
|
OK, it only accepts a single float, though? So it should not be plural. |
|
I agree with @QuLogic While the argument is |
|
I agree with you both. My concern was about not adding confusion in the user's mind, despite it's less logical to name it linewidths. |
QuLogic
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Contours plots are often more beautiful when line widths are smaller
than line widths that are generally used for curves.
This is especially true when
contouris used withcontourf, or whenthe number of levels if high.
With this PR, one can change default value for contour linewidths independently from normal line widths. The new options is
"contour.linewidths", which defaults toNone. When value isNone, it falls back to"lines.linewidth"like before.PR Checklist