Skip to content

Reuse inset_axes locator machinery for secondary_axes. #17249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Reuse inset_axes locator machinery for secondary_axes. #17249

wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 27, 2020

_make_secondary_locator is just a special-case of _make_inset_locator,
so just use the latter.

Also change _make_inset_locator to use transform subtraction instead of
.inverted(), as it is typically more precise (as discussed in #17206).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Reuse inset_axes locator machinery for secondary_axes.
bfca92e 
_make_secondary_locator is just a special-case of _make_inset_locator,
so just use the latter.

Also change _make_inset_locator to use transform subtraction instead of
`.inverted()`, as it is typically more precise.
@QuLogic
Copy link
Member

QuLogic commented May 9, 2020

Seems like an alternate to #14463? Better or worse?

@anntzer
Copy link
Contributor Author

anntzer commented May 9, 2020

There's some overlap, but I think they can both go in? (I can rebase either way.)

@anntzer anntzer mentioned this pull request Jul 21, 2020
Merged
6 tasks
@QuLogic
Copy link
Member

QuLogic commented Jul 22, 2020

#17993 replaces this.

@QuLogic QuLogic closed this Jul 22, 2020
@anntzer anntzer deleted the secondary branch July 22, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Maintenance status: duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @QuLogic