Improve ps handling of individual usetex strings. #17256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6034f4 to
e8fc2f0
Compare
The ps backend currently determines usetex status solely based on the rcparam at renderer instantiation time; in particular, having single Text objects with usetex=True in an otherwise usetex=False renderer currently results in an AttributeError. Instead, detect that and do a best-effort fix which is to try rendering with mathtext instead of usetex. (Actually fixing the ps backend would be nicer, but a bit of work.) Also fix another ps test to not use a temporary directory.
e8fc2f0 to
6cb9d62
Compare
QuLogic
approved these changes
May 5, 2020
timhoffm
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ps backend currently determines usetex status solely based on the
rcparam at renderer instantiation time; in particular, having single
Text objects with usetex=True in an otherwise usetex=False renderer
currently results in an AttributeError. Instead, detect that and do a
best-effort fix which is to try rendering with mathtext instead of
usetex.
(Actually fixing the ps backend would be nicer, but a bit of work.)
Also fix another ps test to not use a temporary directory.
See #7741.
PR Summary
PR Checklist