Backport eps work #17257
Merged
Backport eps work #17257
+122
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define \mathdefault as a noop in the usetex preamble.
Conflicts:
lib/matplotlib/ticker.py
change of a near-by conditional from np.abs -> abs caused
conflict
Fix use of psfrags in ps backend + usetex.
Conflicts:
lib/matplotlib/backends/backend_ps.py
- near by change of rcParams -> mpl.rcParams
lib/matplotlib/texmanager.py
- do not implicitly backport rcParam deprecations
Fix baseline alignment when using usetex.
Conflicts:
lib/matplotlib/tests/test_usetex.py
- import np and formatting issues on decorator
FIX: eps + usetex combo.
|
The reason I didn't write a test is that ghostscript actually doesn't error when rendering the "bad" ps files, just gives a blank page, and as usual I didn't want to add a baseline image. I guess one could use the usual trick of rendering the thing, "manually" (i.e. by calling ghostscript in the test) converting to png, and checking that the page isn't all white... |
|
I went through a very similar thought process. Would it be reliable to render the example @QuLogic came up with verify that the mediabox is correct? |
|
I guess "yes", but it's really a super indirect test, it wouldn't be obvious at all why these values are the correct ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is the stack of PRs that I had to backport to make them all apply relatively cleanly. All are arguably bug-fixes. The 2nd (#16913) and 4th (#17255 ) are the likely the critical ones.
I have verified that the example from #17253 works. Probably should add that as a test...
(re) closes #17253.