Improve info logged by tex subsystem. #17258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Call kpsewhich in text mode (with the correct encoding). - Suppress empty stdout/stderr from logged outputs. Together this changes the entries logged by dviread from ``` DEBUG:matplotlib.dviread:kpsewhich cmss10.tfm DEBUG:matplotlib.dviread:stdout: b'/usr/local/texlive/2019/texmf-dist/fonts/tfm/public/cm/cmss10.tfm\n' DEBUG:matplotlib.dviread:stderr: b'' ``` to ``` DEBUG:matplotlib.dviread:kpsewhich cmss10.tfm DEBUG:matplotlib.dviread:stdout: /usr/local/texlive/2019/texmf-dist/fonts/tfm/public/cm/cmss10.tfm ``` - Fix logged info about loading of tex fonts (it's the font that matters, not the font family).
QuLogic
approved these changes
Apr 29, 2020
timhoffm
reviewed
Apr 29, 2020
| @@ -1079,10 +1082,7 @@ def find_tex_file(filename, format=None): | |||
| result = cbook._check_and_log_subprocess(cmd, _log, **kwargs) | |||
| except RuntimeError: | |||
| return '' | |||
| if os.name == 'nt': | |||
| return result.decode('utf-8').rstrip('\r\n') | |||
There was a problem hiding this comment.
Why don't we have to strip the \r anymore?
There was a problem hiding this comment.
because passing an encoding also turns on newline conversion, per https://docs.python.org/3/library/subprocess.html#frequently-used-arguments.
timhoffm
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together this changes the entries logged by dviread from
to
matters, not the font family).
PR Summary
PR Checklist