Deprecate various wx Toolbar attributes. #17292
Merged
+71
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
May 1, 2020
These are clearly internal helpers involved in zoombox drawing, and will likely be changed soon anyways.
timhoffm
approved these changes
May 1, 2020
QuLogic
approved these changes
May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are clearly internal helpers involved in zoombox drawing, and will
likely be changed soon anyways (#11944).
This may be nice to get in 3.3 if we want to consider #11944 for 3.4, so marking as RC, but feel free to untag if you disagree.
PR Summary
PR Checklist