Skip to content

Avoid "dash motion" in qt zoom box. #17299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2020
Merged

Avoid "dash motion" in qt zoom box. #17299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions lib/matplotlib/backends/backend_qt5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,16 +478,23 @@ def drawRectangle(self, rect):
# Draw the zoom rectangle to the QPainter. _draw_rect_callback needs
# to be called at the end of paintEvent.
if rect is not None:
x0, y0, w, h = [pt / self._dpi_ratio for pt in rect]
x1 = x0 + w
y1 = y0 + h
def _draw_rect_callback(painter):
scaled_rect = [pt / self._dpi_ratio for pt in rect]
pen = QtGui.QPen(QtCore.Qt.black, 1 / self._dpi_ratio)
pen.setDashPattern([3, 3])
painter.setPen(pen)
painter.drawRect(*scaled_rect)
pen.setDashOffset(3)
pen.setColor(QtCore.Qt.white)
painter.setPen(pen)
painter.drawRect(*scaled_rect)
for color, offset in [
(QtCore.Qt.black, 0), (QtCore.Qt.white, 3)]:
pen.setDashOffset(offset)
pen.setColor(color)
painter.setPen(pen)
# Draw the lines from x0, y0 towards x1, y1 so that the
# dashes don't "jump" when moving the zoom box.
painter.drawLine(x0, y0, x0, y1)
painter.drawLine(x0, y0, x1, y0)
painter.drawLine(x0, y1, x1, y1)
painter.drawLine(x1, y0, x1, y1)
else:
def _draw_rect_callback(painter):
return
Expand Down