Fix alignment of offset text on top axis. #17302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
May 2, 2020
|
Marking as release-critical because this has been introduced for 3.3 and we'd better start with a non-buggy version right away. |
When set to show offset text on the top, the alignment is set to top, but that's the same alignment as if it were on the bottom. It should be set to bottom instead, or it will overlap with ticks.
jklymak
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This was added in #15592, but with the wrong alignment. When set to show offset text on the top, the alignment is set to top, but that's the same alignment as if it were on the bottom. It should be set to bottom instead, or it will overlap with ticks.
On master, you get:
but it should be (in this PR):
PR Checklist