Skip to content

DOC: add offset axes to secondary_axes #17324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2020
Merged

DOC: add offset axes to secondary_axes #17324

merged 2 commits into from
May 4, 2020

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented May 4, 2020 •
edited
Loading

PR Summary

On stackoverflow, someone found secondary_xaxis but didn't realize that the location could be a float. This improves the last example to make that clear.

Figure_1

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak force-pushed the doc-improve-secax branch from ebcda9a to 44d46ed Compare May 4, 2020 18:04
timhoffm
timhoffm reviewed May 4, 2020
View reviewed changes
@jklymak @timhoffm
Update examples/subplots_axes_and_figures/secondary_axis.py
392e3da 
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@timhoffm
Copy link
Member

timhoffm commented May 4, 2020

Anybody can merge after CI pass.

@jklymak jklymak merged commit 6621c55 into matplotlib:master May 4, 2020
@jklymak jklymak deleted the doc-improve-secax branch May 5, 2020 00:03
@QuLogic QuLogic added this to the v3.3.0 milestone May 5, 2020
@scimax
Copy link

scimax commented May 5, 2020

Thanks for the help and directly adding this to the documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jklymak @timhoffm @scimax @QuLogic