Don't duplicate docstrings of pyplot-level cmap setters. #17389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamically generating these docstrings takes ~40us, which is negligible compared to the import time. flake8 had to be updated, as older versions incorrectly warned about the lack of blank lines between the one-liners.
tacaswell
approved these changes
May 12, 2020
timhoffm
approved these changes
May 12, 2020
|
3.3 is not yet branched. Either we wait or milestone this for 3.3. |
|
I'm not in a hurry. |
|
Doers this need to wait for the branch? Not sure I understand why we don't just merge for 3.3? |
|
I'm unclear why azure is failing. Otherwise we could re-target this to 3.3 and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically generating these docstrings takes ~40us, which is
negligible compared to the import time.
flake8 had to be updated, as older versions incorrectly warned about the
lack of blank lines between the one-liners.
PR Summary
PR Checklist