Skip to content

FIX: cancel pending autoscale on manually setting limits #17408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2020

Conversation

tacaswell
Copy link
Member

closes #17331

PR Summary

Applies patch suggested by @anntzer in #17331 (comment)

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant

@tacaswell tacaswell added this to the v3.2.2 milestone May 14, 2020
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label May 14, 2020
@QuLogic
Copy link
Member

QuLogic commented May 15, 2020

#17331 says that auto=True also changed, but there's no test for that here. Is that also fixed by this?

@tacaswell
Copy link
Member Author

Not, sure will look at that tomorrow.

@tacaswell
Copy link
Member Author

The auto keyword is about what state the autoscale is left in after setting the ylim, not if autoscaling should be merged with the current limits. That is, it controls if the next time you add an artist it will re-scale of if the limits are now fixed.

It is orthogonal to the bug, but I added a test for it while we are thinking about it (and added a symmetrical test of set_xlim)

@WeatherGod
Copy link
Member

I think you need to do the same for the set_zlim() for mplot3d? (or maybe it is taken care of through inheritance?)

@tacaswell
Copy link
Member Author

The zlim does not participate in the lazy view lim setting 🤷‍♂️ so it was unaffected by this bug.

@WeatherGod WeatherGod merged commit c7a6b12 into matplotlib:master May 28, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented May 28, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 c7a6b12e103e582a3adb5960bd19f68489511ece
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #17408: FIX: cancel pending autoscale on manually setting limits'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-17408-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #17408 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surprising/changed axis limit (autoscale) behavior
5 participants