Reorder NavigationToolbar2 methods. #17416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR only moves methods around, and does not change any actual implementation code. Right now NavigationToolbar2 methods are implemented in a very haphazard order. In particular the successively called event handlers for interactive panning and zooming are not defined next to one another, which makes logic hard to follow. This PR moves `home`, `back` and `forward` next to one another (in the same order as they appear in the toolbar); `pan`, `press_pan`, `drag_pan`, and `release_pan` next to one another in that order; and likewise for `zoom`, `press_zoom`, `drag_zoom`, and `release_zoom`.
QuLogic
approved these changes
May 19, 2020
timhoffm
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only moves methods around, and does not change any actual
implementation code.
Right now NavigationToolbar2 methods are implemented in a very haphazard
order. In particular the successively called event handlers for
interactive panning and zooming are not defined next to one another,
which makes logic hard to follow. This PR moves
home,backandforwardnext to one another (in the same order as they appear inthe toolbar);
pan,press_pan,drag_pan, andrelease_pannextto one another in that order; and likewise for
zoom,press_zoom,drag_zoom, andrelease_zoom.PR Summary
PR Checklist