-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
constrained_layout rewrite.... #17437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rebasing for this is going to be a big PITA because I have so much re-organization in |
Closing this for now in lieu of #17494 which doesn't have any of the changes to figure and subpanel. |
PR Summary
Just a draft for now, but this is meant to be substantially simpler than the current
constrained_layout
and more robust. Some of the flakiness should be gone. Colorbars are better located, and respect their anchors now.This version includes the idea of
figure.sub_panels
, but that could be (reluctantly) taken out if its deemed not useful. It does get you nice things like:It wold have been nice to do them separately but it was pretty hard to make sure everything works for the nesting....
Most of the constrained_layout baseline images have changed, but thats because colorbar sizing has changed (for the better), and small changes to how padding is handled. I don't feel any of the choices made here make any of the images worse, and I don't think its worth trying to make them the same. I could be convinced to change a lot of these to assertions on the position of the axes, but its then a challenge to see what goes wrong if they break.
subpanel
.PR Checklist