-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
MEP30: make each "pseudotype" a class #17446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In the specific case of capstyle and joinstyle, I think it should be relatively easy* to turn them into StrEnums (like IntEnums, but for strs...), i.e.
and put the doc there together with whatever relevant methods, and just call it a day. (*for mpl-specific values of "easy", conditions may apply) |
A discussed on the call, I like this ideas in terms of documentation/writing a matplotlib user manual of sorts... I'm way more hesitant about it as code w/out a clear articulation of which parameters should be pseudotypes. But as a first pass, I think this intersects w/ #6738 since doing that properly would require a validation method per parameter. |
xref #14642 on enums. Also, s/matplotlib/Matplotlib/g, mostly. |
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it. |
I propse to close this as too heavy. I think the solution is somewhere between |
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it. |
PR Summary
Hopefully I set this up correctly, looking forward to discussion!