Skip to content

Deprecate the private FigureCanvasGTK3._renderer_init. #17461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2020
Merged

Deprecate the private FigureCanvasGTK3._renderer_init. #17461

merged 1 commit into from
May 22, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 20, 2020

Previously, subclasses of FigureCanvasGTK3 needed to override the
undocumented _renderer_init method. Instead, just move the relevant
initialization code to the subclass' __init__. (Conceptually this is
similar to the deprecation of _init_toolbar method on toolbars.)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.3.0 milestone May 21, 2020
@QuLogic
Copy link
Member

QuLogic commented May 21, 2020

CI says this is not quite right.

@anntzer
Deprecate the private FigureCanvasGTK3._renderer_init.
edcc3c3 
Previously, subclasses of FigureCanvasGTK3 needed to override the
undocumented `_renderer_init` method.  Instead, just move the relevant
initialization code to the subclass' `__init__`.  (Conceptually this is
similar to the deprecation of `_init_toolbar` method on toolbars.)
@anntzer
Copy link
Contributor Author

anntzer commented May 21, 2020

yup, hopefully better now...

@anntzer anntzer force-pushed the unrenderer_init branch from 1373591 to edcc3c3 Compare May 21, 2020 07:07
@tacaswell tacaswell merged commit 3816dff into matplotlib:master May 22, 2020
@anntzer anntzer deleted the unrenderer_init branch May 22, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
GUI: gtk
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @tacaswell