Skip to content

Shorten RectangleSelector._release. #17482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2020
Merged

Shorten RectangleSelector._release. #17482

merged 1 commit into from
May 22, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 21, 2020

Just get rid of plenty of temporary variables (xmin, xmax, ymin, ymax,
xproblems, yproblems) which obscure the actual (simple!) computation
that matters.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Shorten RectangleSelector._release.
81a9396 
Just get rid of plenty of temporary variables (xmin, xmax, ymin, ymax,
xproblems, yproblems) which obscure the actual (simple!) computation
that matters.
@QuLogic QuLogic merged commit d03c337 into matplotlib:master May 22, 2020
@QuLogic QuLogic added this to the v3.3.0 milestone May 22, 2020
@anntzer anntzer deleted the rsx branch May 22, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: widgets/UI
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm