Skip to content

Fix exception handling in FT2Font init. #17510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2020
Merged

Fix exception handling in FT2Font init. #17510

merged 1 commit into from
Jun 1, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented May 26, 2020

PR Summary

It needs to return -1 when an exception is set, or Python raises a SystemError instead.

Missed this in #15104.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: text/fonts labels May 26, 2020
@QuLogic QuLogic added this to the v3.3.0 milestone May 26, 2020
@QuLogic QuLogic requested a review from anntzer May 26, 2020 02:18
anntzer
anntzer reviewed May 26, 2020
View reviewed changes
anntzer
anntzer reviewed May 26, 2020
View reviewed changes
@QuLogic
Fix exception handling in FT2Font init.
699a03b 
It needs to return -1 when an exception is set, or Python raises a
`SystemError` instead.
anntzer
anntzer approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postci
thanks for cleaning up my mess :)

@jklymak jklymak merged commit c5c12dd into matplotlib:master Jun 1, 2020
@QuLogic QuLogic deleted the invalid-font branch June 1, 2020 19:43
@Anthchirp Anthchirp mentioned this pull request Jul 9, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: text/fonts
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @anntzer @jklymak