Skip to content

Resolving Issue #1737 - MacOSX backend unicode problems in python 3.3 #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 20, 2013
Merged

Resolving Issue #1737 - MacOSX backend unicode problems in python 3.3 #1753

merged 5 commits into from
May 20, 2013

Conversation

bingjeff
Copy link
Contributor

This is to resolve an issue with the macosx backend when using Python 3.3 that the text printed during plots is only half of the string. I have resolved my issues, but I would request that someone knowledgable in objective-c and python take a look.

@bingjeff
Fix of macosx text rendering truncation with edit
f6382fe 
of _macosx to overcome change in Py_UNICODE size
that occurred in Python3.3
@bingjeff
Rollback of error introduced in
6433af0 
GraphicsContext_draw_image from previous commit.
@bingjeff
Copy link
Contributor Author

The Travis build failed initially, but it builds on my machine OSX 10.7.5 using matplotlib at tag v1.2.0, Python 3.3.0 and Numpy 1.7.

@bingjeff bingjeff mentioned this pull request Feb 19, 2013
Closed
@ghost ghost assigned dmcdougall Mar 29, 2013
@pelson
Copy link
Member

pelson commented Apr 18, 2013

@dmcdougall / @mdehoon - are either of you in a position to try this out?

@pelson
Copy link
Member

pelson commented Apr 18, 2013

@mdehoon wrote:

@bingjeff : Thanks for providing the pull request. It seems to work fine for Python 3.3, but it breaks unicode handling for Python 2. For example, try running unicode_demo.py in examples/pylab_examples. So I think we need to add #ifdef's to GraphicsContext_draw_text to keep using the old code for Python 2.

@bingjeff
Copy link
Contributor Author

@pelson and @mdehoon I finally wrapped everything in #ifdefs hopefully this works now?

@mdboom
Copy link
Member

mdboom commented Apr 23, 2013

Just a note -- I think this is important enough that we should backport this to v1.2.x before or after merging.

@pelson pelson mentioned this pull request Apr 24, 2013
Closed
@mdboom
Copy link
Member

mdboom commented May 10, 2013

What's the status of this? I don't have a Mac handy -- if someone can confirm this works on "not Damon's" Mac, I think this looks good to merge.

@cimarronm
Copy link
Contributor

This patch works for me

mdboom added a commit that referenced this pull request May 20, 2013
@mdboom
Merge pull request #1753 from bingjeff/master
016d120 
Resolving Issue #1737 - MacOSX backend unicode problems in python 3.3
@mdboom mdboom merged commit 016d120 into matplotlib:master May 20, 2013
@dmcdougall dmcdougall mentioned this pull request Jun 16, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dmcdougall dmcdougall

Labels
None yet
Projects
None yet
Milestone
v1.3.x blocker
Development

Successfully merging this pull request may close these issues.
5 participants
@bingjeff @pelson @mdboom @cimarronm @dmcdougall