Skip to content

Update subplot2grid doc to use Figure.add_gridspec, not GridSpec. #17550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2020
Merged

Update subplot2grid doc to use Figure.add_gridspec, not GridSpec. #17550

merged 1 commit into from
Jun 5, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 1, 2020

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

QuLogic
QuLogic reviewed Jun 2, 2020
View reviewed changes
efiring
efiring approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but it points to a need for a follow-up unless this PR is augmented.

@efiring
Copy link
Member

efiring commented Jun 3, 2020

@QuLogic This is not milestoned, but if it wouldn't interfere with your tagging activities then I suggest you go ahead and merge this.

QuLogic
QuLogic reviewed Jun 5, 2020
View reviewed changes
@QuLogic QuLogic added this to the v3.3.0 milestone Jun 5, 2020
@QuLogic QuLogic merged commit 9c35cae into matplotlib:master Jun 5, 2020
@QuLogic QuLogic mentioned this pull request Jun 5, 2020
Merged
2 tasks
@anntzer anntzer deleted the s2g branch June 5, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

@QuLogic QuLogic QuLogic left review comments

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @efiring @QuLogic @timhoffm