Skip to content

Examples: fix formatting issue in 'Errorbar limit selection' #17573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2020
Merged

Examples: fix formatting issue in 'Errorbar limit selection' #17573

merged 1 commit into from
Jun 4, 2020
+1 −1

Conversation

sadielbartholomew
Copy link
Contributor

PR Summary

I noticed a minor formatting issue (backticks being displayed due to missing space after a literal item) in the text in the 'Errorbar limit selection' example page that has not been picked up on or fixed in master (as far as I can tell by searching the PRs/ issues from some keywords), & since I had forked the repo already to submit another PR thought I would raise it here. Thanks.

PR Checklist

[Only one checklist item applicable:]

- [ ] Has Pytest style unit tests
- [ ] Code is Flake 8 compliant
- [ ] New features are documented, with examples if plot related

  • Documentation is sphinx and numpydoc compliant

- [ ] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
- [ ] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@sadielbartholomew sadielbartholomew changed the title Examples: fix formatting issue in 'Errorbar limit selection' page Examples: fix formatting issue in 'Errorbar limit selection' Jun 4, 2020
@sadielbartholomew
Copy link
Contributor Author

I'm not sure what those two test job failures pertain to, as I am not willing to sign up to CircleCI which blocks me from seeing anything except, in the "... artifact" job, a message "Artifact not found" which means nothing to me. Let me know if there's anything I need to do. Thanks.

@timhoffm
Copy link
Member

timhoffm commented Jun 4, 2020

The install did not run cleanly on circle/CI docs-python38:

    running build_ext
    creating tmp
    gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/usr/local/include/python3.8 -c /tmp/tmpwhirk_7o.cpp -o tmp/tmpwhirk_7o.o -fvisibility=hidden
    gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/usr/local/include/python3.8 -c /tmp/tmpkgc89f9_.cpp -o tmp/tmpkgc89f9_.o -fvisibility-inlines-hidden
    gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/usr/local/include/python3.8 -c /tmp/tmp8k4iwcwd.cpp -o tmp/tmp8k4iwcwd.o -flto

Too long with no output (exceeded 10m0s): context deadline exceeded

I've restarted to see if this is a persistent problem.

timhoffm
timhoffm approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the CircleCI run before merging, but it seems clearly unrelated to the PR.

@QuLogic QuLogic merged commit af7beaa into matplotlib:master Jun 4, 2020
@QuLogic QuLogic added this to the v3.3.0 milestone Jun 4, 2020
@sadielbartholomew sadielbartholomew deleted the formatting-errorbar-limit-sel-example branch June 4, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sadielbartholomew @timhoffm @QuLogic