FIX: propagate _is_saving state when changing canvases #17602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have logic to draw animated artists if we are rendering due to savefig (as opposed to rendering to put into a GUI). Not every canvas class can write every format so we can switch the canvas as save time based on the requested extension / format. Make sure we set the sate on the canvas we are actually using to save the figure rather than the canvas that is attached to the figure when we start saving. closes matplotlib#17599
QuLogic
approved these changes
Jun 10, 2020
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Jun 10, 2020
…anging canvases Merge pull request matplotlib#17602 from tacaswell/fix_mixed_canvas_animation_save FIX: propagate _is_saving state when changing canvases Conflicts: lib/matplotlib/backend_bases.py - other nearby changes, only backport the context manager related changes lib/matplotlib/tests/test_figure.py - did not backport the other tests that are currently only on master branch.
QuLogic
added a commit
that referenced
this pull request
Jun 10, 2020
…-v3.2.x Backport PR #17602: FIX: propagate _is_saving state when changing can…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
We have logic to draw animated artists if we are rendering due to
savefig (as opposed to rendering to put into a GUI). Not every canvas
class can write every format so we can switch the canvas as save time
based on the requested extension / format. Make sure we set the sate
on the canvas we are actually using to save the figure rather than the
canvas that is attached to the figure when we start saving.
closes #17599
PR Checklist