Skip to content

Move codecov.yml to .github. #17606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2020
Merged

Move codecov.yml to .github. #17606

merged 1 commit into from
Jun 10, 2020
+2 −2

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jun 10, 2020

PR Summary

Then removing the -y argument to the script fixes a deprecation warning from it. I don't know when the flag will go away, but I noticed it in the build logs.

PR Checklist

  • [N/A] Has Pytest style unit tests
  • [N/A] Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic
Move codecov.yml to .github.
2fad6aa 
Then removing the `-y` argument to the script fixes a deprecation
warning from it.
@QuLogic QuLogic added this to the v3.2.2 milestone Jun 10, 2020
timhoffm
timhoffm approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, here is where the file can be placed.

https://docs.codecov.io/docs/codecov-yaml#can-i-name-the-file-codecovyml

@tacaswell tacaswell merged commit c9c9014 into matplotlib:master Jun 10, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented Jun 10, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 c9c9014e40322d605ee47c1b171f12f90a7296a5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #17606: Move codecov.yml to .github.'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-17606-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #17606 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@QuLogic QuLogic deleted the codecov-warnings branch June 10, 2020 20:46
@QuLogic
Copy link
Member Author

QuLogic commented Jun 10, 2020

So it turns out we don't use -y on v3.2.x; not sure if codecov just wasn't uploading correctly on that branch.

@QuLogic QuLogic mentioned this pull request Jun 10, 2020
Merged
tacaswell added a commit that referenced this pull request Jun 11, 2020
@tacaswell
Merge pull request #17611 from QuLogic/codecov-warnings
56270eb 
Backport #17606 to v3.2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @timhoffm @tacaswell