Skip to content

MNT: allow 0 sized figures #17610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

MNT: allow 0 sized figures #17610

merged 1 commit into from
Jun 11, 2020

Conversation

tacaswell
Copy link
Member

PR Summary

This can happen if the figure is embedded in a larger GUI application.

Closes #17093

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant

@tacaswell
MNT: allow 0 sized figures
4b3301f 
This can happen if the figure is embedded in a larger GUI application.

Closes matplotlib#17093
@tacaswell tacaswell added this to the v3.3.0 milestone Jun 10, 2020
QuLogic
QuLogic approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't seem too fatal in my testing, other than Pillow raising weirder errors than it should.

@tacaswell tacaswell mentioned this pull request Jun 11, 2020
Closed
@jklymak jklymak merged commit 2348faa into matplotlib:master Jun 11, 2020
@tacaswell tacaswell deleted the enh_zero_size_figure branch June 12, 2020 03:09
@QuLogic QuLogic mentioned this pull request Jun 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

Zero size figure use case
3 participants
@tacaswell @QuLogic @jklymak