Skip to content

Unbreak setattr_cm + mplcairo. #17648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Unbreak setattr_cm + mplcairo. #17648

wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 16, 2020

PR Summary

Closes #17646, see description there.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jun 16, 2020
@anntzer anntzer added this to the v3.3.0 milestone Jun 16, 2020
@tacaswell tacaswell mentioned this pull request Jun 16, 2020
Merged
2 tasks
@tacaswell tacaswell modified the milestones: v3.3.0, v3.2.2 Jun 16, 2020
tacaswell
tacaswell approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 on either this or #17649 going in.

@anntzer
Copy link
Contributor Author

anntzer commented Jun 16, 2020

#17649 seems better.

@anntzer anntzer closed this Jun 16, 2020
@anntzer anntzer deleted the setattr_cm branch June 16, 2020 19:17
@tacaswell tacaswell modified the milestones: v3.3.0, unassigned Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

more conservative setattr_cm broke mplcairo
2 participants
@anntzer @tacaswell