Fix default colouring of Shadows #17656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with matplotlib#16098, extra keyword arguments are now processed, but that means that default colours and alpha are not set. Instead, those properties should only be overridden if specified.
A `Shadow` already sets zorder immediately below its parent patch, so that's no longer necessary.
timhoffm
reviewed
Jun 17, 2020
| @@ -3076,8 +3076,7 @@ def get_next_color(): | |||
| if shadow: | |||
| # Make sure to add a shadow after the call to add_patch so the | |||
| # figure and transform props will be set. | |||
| shad = mpatches.Shadow(w, -0.02, -0.02) | |||
| shad.set(zorder=0.9 * w.get_zorder(), label='_nolegend_') | |||
| shad = mpatches.Shadow(w, -0.02, -0.02, label='_nolegend_') | |||
There was a problem hiding this comment.
Shadow sets a default zorder (immediately below the parent patch) that's better than this manually calculated one.
timhoffm
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Starting with #16098, extra keyword arguments are now processed, but that means that default colours and alpha are not set. Instead, those properties should only be overridden if specified.
As a proof that this works as one might expect, change the
Shadowcall inpieto use keyword arguments instead of.set.This is not a perfect match to previous behaviour, but at least makes the constructor work in an expected manner.
PR Checklist