Skip to content

Don't linewrap css in svg header. #17667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2020
Merged

Don't linewrap css in svg header. #17667

merged 1 commit into from
Jun 18, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 18, 2020

Output the tiny bit of CSS in every SVG header as

  <style type="text/css">*{stroke-linecap:butt;stroke-linejoin:round;}</style>

instead of the slightly weirdly indented

  <style type="text/css">
*{stroke-linecap:butt;stroke-linejoin:round;}
  </style>

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Don't linewrap css in svg header.
ec91829 
Output the tiny bit of CSS in every SVG header as
```xml
  <style type="text/css">*{stroke-linecap:butt;stroke-linejoin:round;}</style>
```
instead of the slightly weirdly indented
```
  <style type="text/css">
*{stroke-linecap:butt;stroke-linejoin:round;}
  </style>
```
@timhoffm timhoffm added this to the v3.3.0 milestone Jun 18, 2020
@timhoffm timhoffm merged commit d779281 into matplotlib:master Jun 18, 2020
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 18, 2020
Merged
@anntzer anntzer deleted the svghead branch June 18, 2020 16:52
tacaswell pushed a commit that referenced this pull request Jun 18, 2020
@timhoffm @meeseeksmachine
Backport PR #17667: Don't linewrap css in svg header.
4611bff
tacaswell added a commit that referenced this pull request Jun 18, 2020
@tacaswell
Merge pull request #17671 from meeseeksmachine/auto-backport-of-pr-17…
68d0e81 
…667-on-v3.3.x

Backport PR #17667 on branch v3.3.x (Don't linewrap css in svg header.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
backend: svg Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @timhoffm