FIX: correctly process the tick label size #17676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Jun 18, 2020
Passing the size positional caused it to be treated as a fontconfig pattern. For the relative sizes without '-' in them this formally works and stashes the relative size in the family. We don't actually resolve that we can _find_ the font so this, while wrong, is not noticed and when we ask for the size it gives us back the default size so our size estimate was silently wrong. In the cases where we have a '-' in the relative size the fontconfig pattern parsing fails when we try to estimate the size. closes matplotlib#17670 Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
302bd90 to
4d2a112
Compare
anntzer
approved these changes
Jun 19, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 19, 2020
tacaswell
added a commit
that referenced
this pull request
Jun 19, 2020
…676-on-v3.3.x Backport PR #17676 on branch v3.3.x (FIX: correctly process the tick label size)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Passing the size positional caused it to be treated as a fontconfig
pattern. For the relative sizes without '-' in them this formally
works and stashes the relative size in the family. We don't actually
resolve that we can find the font so this, while wrong, is not
noticed and when we ask for the size it gives us back the default
size so our size estimate was silently wrong.
In the cases where we have a '-' in the relative size the fontconfig
pattern parsing fails when we try to estimate the size.
closes #17670
PR Checklist