Skip to content
/ matplotlib Public
  • PHP-Proxy

    PHP-Proxy

    Error accessing resource: 429 - Too Many Requests

  • Notifications You must be signed in to change notification settings
  • Fork 7.9k
  • Star 21.3k

Deprecate FigureCanvas.{get,set}_window_title. #17723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2020
Merged

Deprecate FigureCanvas.{get,set}_window_title. #17723

merged 1 commit into from
Jun 30, 2020
PHP-Proxy

PHP-Proxy

Error accessing resource: 429 - Too Many Requests

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 22, 2020

This really belongs on the manager, and is a mild footgun on the canvas.

See discussion at #17721.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
PHP-Proxy

PHP-Proxy

Error accessing resource: 429 - Too Many Requests

@anntzer anntzer added this to the v3.4.0 milestone Jun 22, 2020
QuLogic
QuLogic reviewed Jun 22, 2020
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tagged for 3.4...

@anntzer
Copy link
Contributor Author

anntzer commented Jun 23, 2020

oops, fixed

@timhoffm
Copy link
Member

CI failure: Tests need to account for the deprecation.

@anntzer
Copy link
Contributor Author

anntzer commented Jun 23, 2020

yup

dstansby
dstansby reviewed Jun 26, 2020
View reviewed changes
@anntzer
Deprecate FigureCanvas.{get,set}_window_title.
21597eb 
This really belongs on the manager, and is a mild footgun on the canvas.
@anntzer
Copy link
Contributor Author

anntzer commented Jun 30, 2020

rebased

@QuLogic QuLogic merged commit 26ed5ee into matplotlib:master Jun 30, 2020
@anntzer anntzer deleted the title branch June 30, 2020 22:09
@QuLogic QuLogic mentioned this pull request Jul 8, 2021
Closed
@gerlero gerlero mentioned this pull request Nov 30, 2022
Closed
mhaberler added a commit to mhaberler/RealtimePlotter that referenced this pull request Apr 8, 2023
@mhaberler
FigureCanvas.set_window_title was deprecated
e44e183 
see matplotlib/matplotlib#17723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic

@timhoffm timhoffm

@dstansby dstansby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

PHP-Proxy

PHP-Proxy

Error accessing resource: 429 - Too Many Requests
4 participants
@anntzer @timhoffm @QuLogic @dstansby