Small cleanups to contour() code. #17754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Jun 25, 2020
lib/matplotlib/cbook/__init__.py
Outdated
| def __init__(self, type, seq=None): | ||
| self.type = type | ||
| if seq is not None: | ||
| self.extend(seq) | ||
|
|
||
| def __repr__(self): | ||
| return '<a list of %d %s objects>' % (len(self), self.type) | ||
| return (f"<a list of {len(self)} {self.type} objects>" | ||
| if self.type is not None else |
There was a problem hiding this comment.
Can you pull out
type_ = self.type if self.type is not None else ...
That'd make the messages simpler to read.
timhoffm
reviewed
Jun 25, 2020
Fully assigning self.collections with a list comprehension makes it clear that there are not earlier elements in self.collections that may stay there. Also, the type used in the repr of the self.collections silent_list can be directly inferred from the list items.
QuLogic
approved these changes
Jun 25, 2020
|
Slight preference those were two commits, maybe. |
timhoffm
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully assigning self.collections with a list comprehension makes it
clear that there are not earlier elements in self.collections that may
stay there.
Also, the type used in the repr of the self.collections silent_list can
be directly inferred from the list items.
PR Summary
PR Checklist