Changes in the image for test_load_from_url #17776
Conversation
| @@ -713,7 +713,7 @@ def test_minimized_rasterized(): | |||
|
|
|||
|
|
|||
| def test_load_from_url(): | |||
| path = Path(__file__).parent / "baseline_images/test_image/imshow.png" | |||
| path = Path(__file__).parent / "baseline_images/pngsuite/basn3p04.png" | |||
There was a problem hiding this comment.
I don't understand why we think this image will be permanent either, and it seems a very obscure image to choose. Isn't there something in mpl_data/images that would be more appropriate?
There was a problem hiding this comment.
This image will remain as it is also used in
matplotlib/lib/matplotlib/tests/test_image.py
Line 151 in 50a535c
Secondly, the
basn3p04.png image is not used in image_comparison tests. So, we don't need to shift it into the mpl_baseline_images package in #17557
There was a problem hiding this comment.
But shouldn’t that be moved as well? It’s going to be pretty confusing to have baseline_images and another package of baseline_images.
There was a problem hiding this comment.
The primary reason the basn*.png files exist is as input for the test in test_png so is not in the category of images that will be removed by the GSOC code landing. On the other hand, the file that this used to point is a baseline image that will be removed.
PR Summary
Image for the test_load_from_url changed so that it can use the images which are not baseline images. This will be later benificial for the division of mpl into mpl and mpl_baseline_images package as #17557
PR Checklist