Tighten a bit the RendererAgg API. #17788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Jul 2, 2020
29c5d11 to
ac64e25
Compare
timhoffm
reviewed
Jul 3, 2020
|
Actually I realized I could also rewrite get_content_extents in terms of _get_nonzero_slices, and immediately kill the C-level get_content_extents (in a second commit). |
timhoffm
approved these changes
Jul 3, 2020
QuLogic
approved these changes
Jul 18, 2020
The get_content_extents and tostring_rgba_minimized methods of RendererAgg are used to implement 1) agg_filter and 2) rasterization in MixedModeRenderer (i.e. for vector backends). They can easily instead be implemented at the Python level (i.e., via _get_nonzero_slices), which makes it easier to plug in an alternative renderer (e.g., mplcairo) for rasterization in MixedModeRenderer. I'm not convinced _get_nonzero_slices needs to be exposed as public API (it's quite simple anyways), but it could be if we absolutely want to present an alternative for the deprecated methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_content_extents and tostring_rgba_minimized methods of
RendererAgg are used to implement 1) agg_filter and 2) rasterization in
MixedModeRenderer (i.e. for vector backends). They can easily instead
be implemented at the Python level (i.e., via _get_nonzero_slices),
which makes it easier to plug in an alternative renderer (e.g.,
mplcairo) for rasterization in MixedModeRenderer. I'm not convinced
_get_nonzero_slices needs to be exposed as public API (it's quite simple
anyways), but it could be if we absolutely want to present an
alternative for the deprecated methods.
PR Summary
PR Checklist