Fix FFMpegBase.isAvailable with detached terminals. #17882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking for ffmpeg/libav, set stdin to /dev/null, otherwise the process will sleep if Python is running with a detached terminal. And we definitely don't want ffmpeg/libav to grab user input here.
dopplershift
approved these changes
Jul 11, 2020
dstansby
approved these changes
Jul 12, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 12, 2020
dstansby
added a commit
that referenced
this pull request
Jul 12, 2020
…882-on-v3.3.x Backport PR #17882 on branch v3.3.x (Fix FFMpegBase.isAvailable with detached terminals.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When checking for ffmpeg/libav, set stdin to /dev/null, otherwise the process will sleep if Python is running with a detached terminal. And we definitely don't want ffmpeg/libav to grab user input here.
I don't think there's any way to test this automatically, really, but if anyone has any ideas...
Fixes #17875.
PR Checklist