frame_format to support all listed by animation writers #17909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y animation writers
timhoffm
reviewed
Jul 13, 2020
timhoffm
approved these changes
Jul 14, 2020
| @@ -204,6 +204,15 @@ def test_Issue_1713(tmpdir): | |||
| assert rc.get('timezone') == 'UTC' | |||
|
|
|||
|
|
|||
| def test_animation_frame_formats(): | |||
| # Animation frame_format should allow any of the following | |||
| # if any of these are not allowed, an exception will be raised | |||
There was a problem hiding this comment.
Optionally add another test checking the exception for this case.
There was a problem hiding this comment.
I can do that, but I think that correctness is implied by an already existing test for validate_stringlist.
QuLogic
approved these changes
Jul 15, 2020
|
Thanks @bmcfee! |
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #17908 . As documented in the issue, various animation writers support different formats, and there is no way to set the format directly from the API. This forces users to go through rcParams, but rcParams only listed a subset of frame formats.
This PR extends the supported frame formats in
rcsetup.pyto support any format supported by at least one writer. If the user selects a format that is not supported by their chosen writer, an exception will be raised at runtime (rather than at configuration time). This will allow a user to, for example, usesvgformat forjshtmloutput, which is not currently possible.PR Checklist