Rewrite the barcode example #17922
Merged
Rewrite the barcode example #17922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd say that in the example? Or do you want it to be an easter egg? |
|
It doesn't really add to the example. So, I'd leave it as an easter egg. But no strong preference. |
QuLogic
reviewed
Jul 15, 2020
This is a bit particular anyway, but let's make it practical by generating a real bar code and not only some random lines. Fun fact: The used code is the GTIN-13 for "The Visual Display of Quantitative Information", Edward R. Tufte.
QuLogic
approved these changes
Jul 15, 2020
jklymak
approved these changes
Jul 15, 2020
| ax2.set_axis_off() | ||
| ax2.imshow(x.reshape((1, -1)), **barprops) | ||
| pixel_per_bar = 4 | ||
| dpi = 100 |
There was a problem hiding this comment.
So not sure this matters, but we save at 200 dpi now, don't we?
There was a problem hiding this comment.
Um, I don't think so. When did that happen?
We now oversample the thumbnails in the gallery (#17734). But that does not affect the images in the examples themselves. Maybe you are mixig this up?
|
I don't think there's any 200 dpi yet, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This example is a bit particular anyway, but let's make it practical by
generating a real bar code and not only some random lines.
Fun fact: The used code is the GTIN-13 for "The Visual Display of
Quantitative Information", Edward R. Tufte.