Skip to content

add test with -OO #17988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 22, 2020
Merged

add test with -OO #17988

merged 6 commits into from
Jul 22, 2020

Conversation

linchiwei123
Copy link
Contributor

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

This simple test may prevent something like issue #17970

QuLogic
QuLogic reviewed Jul 21, 2020
View reviewed changes
@linchiwei123 @QuLogic
Use a list, not a string.
bf6f203 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@tacaswell tacaswell added this to the v3.4.0 milestone Jul 21, 2020
QuLogic
QuLogic reviewed Jul 21, 2020
View reviewed changes
tacaswell
tacaswell approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to squash-merging this as well

@QuLogic QuLogic merged commit 019a752 into matplotlib:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@tacaswell tacaswell tacaswell approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@linchiwei123 @tacaswell @QuLogic @dstansby