Agg snapping fixes (for the last time...?) :) #1800
Conversation
… (see there for further discussion) and matplotlib#1591. This, unlike matplotlib#800, doesn't change the snapping in a fundamental way, but it does help with text/image/marker alignment of snapped and non-snapped objects.
|
I found another snapping issue today which this PR fixes. So that's a circumstantial 👍 from me. I'm not sure about the One solution which would make the decision easier: We could always pop out a |
|
I think I lean toward 1.2.1 as well, but could be convinced otherwise if any convincing arguments existed. I was thinking this was the last bit of work before a 1.2.1rc this week, but then I got the norovirus, so this may get pushed into next week. |
|
Ok -- assuming further lack of strong opinions, I'm going to merge this onto 1.2.x. @pelson: Would your new snapping issue translate into a good test to add? |
Agg snapping fixes (for the last time...?) :)
Fix a number of snapping issues. Incorporates ideas from #800 (see there for further discussion) and #1591. This, unlike #800, doesn't change the snapping in a fundamental way, but it does help with text/image/marker alignment of snapped and non-snapped objects.
This, unfortunately necessarily, updates all of the PNG baseline images.
We should consider whether we want this on v1.2.x or on master -- on some level it's a bug fix by making elements line up better. On another level, it's changing behavior, albeit at the subpixel level.