Skip to content

Deprecate the unneeded Fonts.destroy. #18003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2020
Merged

Deprecate the unneeded Fonts.destroy. #18003

merged 1 commit into from
Jul 21, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 21, 2020

Neither used_characters nor glyphd cause circular references, so we
can let the normal refcount collector handle the destruction.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.4.0 milestone Jul 21, 2020
@anntzer
Deprecate the unneeded Fonts.destroy.
a695e93 
Neither `used_characters` nor `glyphd` cause circular references, so we
can let the normal refcount collector handle the destruction.
@QuLogic QuLogic merged commit c8d9e8d into matplotlib:master Jul 21, 2020
@anntzer anntzer deleted the undestroy branch July 21, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: text/mathtext
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @timhoffm @QuLogic