Skip to content

FIX: use internal _set_postion, not external #18038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2020
Merged

FIX: use internal _set_postion, not external #18038

merged 2 commits into from
Jul 23, 2020

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Jul 23, 2020

PR Summary

Closes #18033

We should always use _set_position internally so we don't signal that the user set the position.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@jklymak jklymak added topic: mplot3d Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: geometry manager LayoutEngine, Constrained layout, Tight layout labels Jul 23, 2020
@jklymak jklymak added this to the v3.3.1 milestone Jul 23, 2020
@jklymak jklymak mentioned this pull request Jul 23, 2020
Closed
@jklymak jklymak force-pushed the fix-mplot3d-aspect-colorbar branch from 05f14ce to 5702e7c Compare July 23, 2020 18:24
@jklymak jklymak force-pushed the fix-mplot3d-aspect-colorbar branch from 5702e7c to 228d997 Compare July 23, 2020 18:27
@WeatherGod WeatherGod merged commit 0a83b9c into matplotlib:master Jul 23, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 23, 2020
@WeatherGod @meeseeksmachine
Backport PR matplotlib#18038: FIX: use internal _set_postion, not ext…
755cb2a 
…ernal
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 23, 2020
Merged
jklymak added a commit that referenced this pull request Jul 23, 2020
@jklymak
Merge pull request #18041 from meeseeksmachine/auto-backport-of-pr-18…
d517420 
…038-on-v3.3.x

Backport PR #18038 on branch v3.3.x (FIX: use internal _set_postion, not external)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@WeatherGod WeatherGod WeatherGod approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: geometry manager LayoutEngine, Constrained layout, Tight layout topic: mplot3d
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.

v. 3.3.0: horizontal colorbar broken
3 participants
@jklymak @tacaswell @WeatherGod