Skip to content

Added figpager info #18059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Added figpager info #18059

merged 1 commit into from
Jul 25, 2020

Conversation

ebenp
Copy link
Contributor

@ebenp ebenp commented Jul 25, 2020

PR Summary

This is a Take #2 of adding a plotting template library called figpager to the third party documentation page in matplotlib. figpager is a plotting library using matplotlib for the subplots and adding in functionality of page size, margins and moving to the next page to create single and multipage documents using matplotlib's figure.

Under the previous draft pull request the framework of matplotlib was added to figpager's setup.py, the figpager header was corrected in index.rst, characters were wrapped at 79 and the example image was compressed using tinypng.com

I previously failed at squashing commits on the PR branch, deleted the repo to try and fix which broke the PR. This is a resubmitted branch with a single commit mirroring the closed PR, but less broken.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [x ] New features are documented, with examples if plot related
  • [ x] Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@ebenp
Copy link
Contributor Author

ebenp commented Jul 25, 2020

The closed PR is here: #18025

@timhoffm timhoffm added this to the v3.3-doc milestone Jul 25, 2020
@timhoffm timhoffm marked this pull request as ready for review July 25, 2020 16:21
@timhoffm timhoffm merged commit cca5b4d into matplotlib:master Jul 25, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 25, 2020
@timhoffm
Copy link
Member

Thanks for you contribution!

dstansby added a commit that referenced this pull request Jul 25, 2020
…059-on-v3.3.0-doc

Backport PR #18059 on branch v3.3.0-doc (Added figpager info)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants