Skip to content

FIX: catch all multi-dim warnings pandas #18101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2020
Merged

FIX: catch all multi-dim warnings pandas #18101

merged 1 commit into from
Jul 28, 2020

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Jul 28, 2020 •
edited
Loading

PR Summary

Pandas emits a warning, which we need to filter in check_1d in order to maintain back-compatibility. They changed the warning type from DeprecationWarning to FutureWarning. Its probably overly fussy to filter twice on each type of warning for different pandas versions, so just filter on a generic warning w/ the correct Warning text.

Note that CI is present broken because there is a new release of pandas today...

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@jklymak jklymak requested a review from tacaswell July 28, 2020 20:32
@jklymak jklymak force-pushed the fix-catch-all-warnings-pandas branch from 658f4f8 to f50b414 Compare July 28, 2020 20:32
@jklymak jklymak added this to the v3.3.1 milestone Jul 28, 2020
@jklymak jklymak added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jul 28, 2020
@jklymak jklymak mentioned this pull request Jul 28, 2020
Merged
6 tasks
@QuLogic
Copy link
Member

QuLogic commented Jul 28, 2020

Merging on one review, because it fixes CI.

@QuLogic QuLogic merged commit 580ae37 into matplotlib:master Jul 28, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 28, 2020
@QuLogic @meeseeksmachine
Backport PR matplotlib#18101: FIX: catch all multi-dim warnings pandas
c2f895c
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 28, 2020
Merged
@timhoffm timhoffm mentioned this pull request Jul 28, 2020
Merged
6 tasks
@jklymak jklymak deleted the fix-catch-all-warnings-pandas branch July 28, 2020 22:44
dopplershift added a commit that referenced this pull request Jul 29, 2020
@dopplershift
Merge pull request #18104 from meeseeksmachine/auto-backport-of-pr-18…
5d166a5 
…101-on-v3.3.x

Backport PR #18101 on branch v3.3.x (FIX: catch all multi-dim warnings pandas)
@zen-juen zen-juen mentioned this pull request Sep 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@tacaswell tacaswell Awaiting requested review from tacaswell

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jklymak @QuLogic