Skip to content

Add option to create horizontally-oriented stem plots #18187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 14, 2020
Merged

Add option to create horizontally-oriented stem plots #18187

merged 8 commits into from
Aug 14, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 6, 2020

PR Summary

This is a rebase and slight squash of #6168. It also fixes the documentation, style, and tests to match current practices.

Fixes #5856.
Closes #6168.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [?] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.4.0 milestone Aug 6, 2020
timhoffm
timhoffm previously requested changes Aug 8, 2020
View reviewed changes
@timhoffm timhoffm mentioned this pull request Aug 8, 2020
Closed
@QuLogic QuLogic force-pushed the 6168-vertical-stem branch from 4cd53fe to b940f57 Compare August 11, 2020 05:04
@QuLogic QuLogic changed the title Add option to create vertically-oriented stem plots Add option to create horizontally-oriented stem plots Aug 11, 2020
timhoffm
timhoffm reviewed Aug 11, 2020
View reviewed changes
vecuenca and others added 7 commits August 12, 2020 23:43
@vecuenca @QuLogic
Add option to create vertically-oriented stem plots
7f10300 
* Added docstrings for optional args in stem, made vertical default to
  false
* Added flipping and renamed xs and ys in stem
@ItsRLuo @QuLogic
Changed orientation variable to string from boolean
a1ebd1f 
Also modified documentation for the change.
Flipped thisx to thisy and vice versa when the orientation value is
vertical
@vecuenca @QuLogic
Added whats_new entry for matplotlib#5856
a1696ca
@vecuenca @QuLogic
Add stem orientation test and associated baseline images
fc6daff 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic
Add validation for the orientation in stem().
77d8cfb
@QuLogic
Rename stem parameters to be clearer.
54258c9 
They are no longer x/y when using a different orientation. Also, this
should fix the unit conversion to use the correct Axis.
@QuLogic
Flip meaning of orientation in stem().
c022b22
@QuLogic QuLogic force-pushed the 6168-vertical-stem branch from b940f57 to 99e7ede Compare August 13, 2020 03:44
timhoffm
timhoffm approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally, use the suggested shorter what's new entry.

@QuLogic QuLogic force-pushed the 6168-vertical-stem branch from 99e7ede to 13d962a Compare August 14, 2020 05:15
@jklymak
Copy link
Member

jklymak commented Aug 14, 2020

CI doesn't pass, but its the MacOS problem not this PR

@jklymak jklymak merged commit ade20db into matplotlib:master Aug 14, 2020
@jklymak
Copy link
Member

jklymak commented Aug 14, 2020

Thanks @vecuenca and @QuLogic ! This looks to be a very useful addition...

@QuLogic QuLogic deleted the 6168-vertical-stem branch August 14, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
New feature
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Horizontal stem plot
5 participants
@QuLogic @jklymak @timhoffm @vecuenca @ItsRLuo