Skip to content

Allow savefig to save SVGs on FIPS enabled systems #18192 #18193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Allow savefig to save SVGs on FIPS enabled systems #18192 #18193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f0b353
Allow savefig to save SVGs on FIPS enabled systems #18192
daytonb Aug 6, 2020
47a0430
Note change of SVG ID generation from MD5 to SHA512 #18192
daytonb Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions doc/api/next_api_changes/behavior/18193-BKB.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
ID attribute of XML tags in SVG files now based on SHA256 rather than MD5
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Matplotlib generates unique ID attributes for various tags in SVG files.
Matplotlib previously generated these unique IDs using the first 10
characters of an MD5 hash. The MD5 hashing algorithm is not available in
Python on systems with Federal Information Processing Standards (FIPS)
enabled. Matplotlib now uses the first 10 characters of an SHA256 hash
instead. SVG files that would otherwise match those saved with earlier
versions of matplotlib, will have different ID attributes.
2 changes: 1 addition & 1 deletion lib/matplotlib/backends/backend_svg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ def _make_id(self, type, content):
salt = mpl.rcParams['svg.hashsalt']
if salt is None:
salt = str(uuid.uuid4())
m = hashlib.md5()
m = hashlib.sha256()
m.update(salt.encode('utf8'))
m.update(str(content).encode('utf8'))
return '%s%s' % (type, m.hexdigest()[:10])
Expand Down