Skip to content

Try out cibuildwheel. #18224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Try out cibuildwheel. #18224

merged 2 commits into from
Aug 12, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 11, 2020

PR Summary

This is enabled for push & pull_request right now, but since we have nowhere to upload anything permanent, I'll probably switch this to tags-only for final usage, if merged.

PR Checklist

  • [n/a] Has Pytest style unit tests
  • [n/a] Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@QuLogic QuLogic added the Build label Aug 11, 2020
@QuLogic QuLogic added this to the v3.3.1 milestone Aug 11, 2020
@QuLogic
Copy link
Member Author

QuLogic commented Aug 11, 2020

Since enabling this on push means it builds on my fork also, I'm trying this out on a separate branch so as to not clog up our other CI.

@QuLogic
Copy link
Member Author

QuLogic commented Aug 11, 2020

This should now be building on all 3 platforms, but it doesn't run any tests. It's also doing manylinux2010 instead of manylinux1, though I'm sure that could be tweaked. GitHub Actions doesn't do arm or s390x, I don't think, so we'd still need the matplotlib-wheels repo to build those.

@@ -0,0 +1,38 @@
name: Build CI wheels

on: [push, pull_request]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to tag?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or, tag + push

This is enabled for push & pull_request right now, but since we have
nowhere to upload anything permanent, I'll probably switch this to
tags-only for final usage, if merged.
@tacaswell tacaswell merged commit 627dd18 into matplotlib:master Aug 12, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 12, 2020
@QuLogic QuLogic deleted the cibuildwheel branch August 12, 2020 18:44
tacaswell added a commit that referenced this pull request Aug 12, 2020
…224-on-v3.3.x

Backport PR #18224 on branch v3.3.x (Try out cibuildwheel.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants