Set pipefail when running flake8 linter. #18227
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the lint will fail if flake8 is broken, otherwise default bash behaviour is to ignore it, if reviewdog exits cleanly.
tacaswell
approved these changes
Aug 12, 2020
|
Given that this is CI configuration I think it is fine to ignore the rest of the CI. I'm going to break protocol a bit and directly merge this. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 12, 2020
dopplershift
added a commit
that referenced
this pull request
Aug 12, 2020
…227-on-v3.3.x Backport PR #18227 on branch v3.3.x (Set pipefail when running flake8 linter.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This ensures that the lint will fail if flake8 is broken, otherwise default bash behaviour is to ignore it, if reviewdog exits cleanly.
See #18200 (review)
PR Checklist