Skip to content

Fix cibuildwheel trigger condition. #18233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 13, 2020
Merged

Fix cibuildwheel trigger condition. #18233

merged 6 commits into from
Aug 13, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 12, 2020

PR Summary

I believe this should be the right filters for what we want. It should build on master, tags, and backport branches, but not doc-backport branches.

PR Checklist

  • [n/a] Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.3.1 milestone Aug 12, 2020
@QuLogic
Copy link
Member Author

QuLogic commented Aug 12, 2020

Of course, now it's not running on pull requests, it doesn't show up here...

@QuLogic
Copy link
Member Author

QuLogic commented Aug 12, 2020

I confirmed by pushing to master on my fork: https://github.com/QuLogic/matplotlib/actions/runs/206023557

@QuLogic QuLogic marked this pull request as draft August 12, 2020 19:38
tacaswell
tacaswell approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so @QuLogic can self-merge when happy.

@QuLogic
Copy link
Member Author

QuLogic commented Aug 13, 2020

I fixed a few more things I noticed: build against oldest supported NumPy, add PyPy (except Windows) and Python 3.6 wheels for 3.3.x, and fix the version tag.

I tested out the Linux wheels which work with old NumPy, and I'm now testing out macOS wheels.

@QuLogic QuLogic marked this pull request as ready for review August 13, 2020 02:35
@QuLogic
Copy link
Member Author

QuLogic commented Aug 13, 2020

I noticed the 3.6 wheels a bit later, but here it is working on master and v3.3.x.

@QuLogic QuLogic merged commit efb93ba into matplotlib:master Aug 13, 2020
@QuLogic QuLogic deleted the fix-ci-trigger branch August 13, 2020 02:45
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 13, 2020
@QuLogic @meeseeksmachine
Backport PR matplotlib#18233: Fix cibuildwheel trigger condition.
254b422
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 13, 2020
Merged
QuLogic added a commit that referenced this pull request Aug 13, 2020
@QuLogic
Merge pull request #18239 from meeseeksmachine/auto-backport-of-pr-18…
4e940b6 
…233-on-v3.3.x

Backport PR #18233 on branch v3.3.x (Fix cibuildwheel trigger condition.)
@QuLogic QuLogic added the Build label Aug 13, 2020
@ksunden ksunden mentioned this pull request Apr 2, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees

@tacaswell tacaswell

Labels
Build
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@QuLogic @tacaswell